Redundant SAR check #6
Loading…
Reference in New Issue
There is no content yet.
Delete Branch "%!s(<nil>)"
Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?
5a766a53ff/src/timdac_ll.c (L68)
This check is redundant -
_sar_search()
already ensures they aren't inverted. It used to be_tune_sar_top == 0 || _tune_sar_bot == UINT16_MAX
, and changing to what it is now created a surprising inflation in code size. I really don't think either of these is necessary and can't really fathom where the previous one came from either. Consider just removing this branch entirely. If the variables got clobbered with invalid numbers somehow, this would result in_sar_search()
flipping them around, maybe settling to an incorrect result once, and then this would get filtered down.