We probably don't actually want clobbers #7

New Issue

Open

opened 2023-01-03 06:46:42 +00:00 by alexisvl · 0 comments

alexisvl commented

2023-01-03 06:46:42 +00:00

Owner

We probably don't actually want clobbers. So far they mostly seem to cause trouble when the comparator gets noisy. They were a solution to two edge cases:

Startup
Power loss and recovery in the hardware

Startup is trivial to handle by just clobbering when _tune == 0, and power loss should result in a fully railed SAR value at one end or the other depending on how the pullup is connected. I suggest a new implementation:

No clobber, except on startup
When the SAR result is fully railed at either end, don't save the result — except on the first round, as a fully railed SAR is a likely result of a poorly selected slope resistor, and it would be much easier to debug if it did capture this once.

We probably don't actually want clobbers. So far they mostly seem to cause trouble when the comparator gets noisy. They were a solution to two edge cases: - Startup - Power loss and recovery in the hardware Startup is trivial to handle by just clobbering when `_tune == 0`, and power loss should result in a fully railed SAR value at one end or the other depending on how the pullup is connected. I suggest a new implementation: - No clobber, except on startup - When the SAR result is fully railed at either end, don't save the result — except on the first round, as a fully railed SAR is a likely result of a poorly selected slope resistor, and it would be much easier to debug if it did capture this once.

alexisvl added this to the 1.0.1 milestone 2023-01-04 03:32:27 +00:00

No Label

No Milestone

No project

No Assignees

1 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: fip/timdac#7

There is no content yet.